Pull Requests
Branches
Bugs
Commands
Integrations
100
What does 🔬'Feature Scope'🔬 mean?
The included functionality of any individual/set of feature(s).
100
What are branches 🎋?
Features you are looking to integrate.
100
Where do we keep track of bugs?
Bugs are tracked in the Github Issue Tracker
100
Command to list branches
git branch -a
100
What should be linked to the Notion doc?
READMEs, instructions, and any permanent/semi-permanent reference material.
200
Should Feature Scope be large or small?
As small as humanly possible.
200
When should you create a branch?
When you're starting a new feature.
200
Should you submit an issue if it's a simple fix?
Yes. Closed issues are a great way to see how someone solved a problem in the past. Plus, a lot of times that simple fix turns into a not so simple fix.
200
Where can I find a cheat sheet for useful Git commands?
On our Notion page!
200
What should be linked to a Trello card?
Issues or documentation relating to a feature-card.
300
How many reviewers are required before a Pull Request can be merged?
At least 1.
300
Max amount of branches that should exist at once?
As many as features that are actively being developed.
300
Who is responsible for fixing a bug?
Everyone.
300
Command for switching branches
git checkout <branch-name>
300
Who is responsible for linking a Trello card to a Pull Request?
The person who opened the Pull Request.
(That being said, if you see one open and it doesn't have a link to a Trello card, go find the card and link it)
400
When is a pull request ready to be merged?
[✔️]Free of bugs
[✔️]No merge conflicts
[✔️]Reviewed by at least 1 collaborator
[✔️]Tested
[✔️]Deployed to Staging Env
400
When should you open a pull request for a branch?
📝Draft pull requests should be opened as soon as the branch is created.
📝Draft PRs should be converted to ➡️ Pull Requests when the feature is complete and tests have been made.
400
What are the workflow steps to complete when you've found a bug?
🚫 Don't panic 🚫
📂 Open a GH Issue
🛤️ Follow the Bug Template
🏷️ Tag it with the appropriate [Priority][Track][Feature]
🔖 Assign team members that are affected/should be made aware
🎉Submit the issue!🎉
400
Command for Creating a New Branch
git checkout -b <feature-name>
400
When should the Notion doc be updated?
After every merged Pull Request.
500
How long should a pull request sit before being reviewed?
No more than 24 hours. Ideally you should be reaching out to team members as soon as a feature is ready to merge and bother them incessantly until they review your PR.
500
When to delete a branch?
1️⃣ After a pull request has been merged to master.
2️⃣ If a feature has been cut from the project.
3️⃣ If a branch was created by accident.
500
Who can close an issue?
Anyone, once the issue has been verified to no longer occur on the live site.
500
Command for Pulling from Master to Update Feature Branch
git checkout <feature-branch>
git fetch origin
git merge origin/master
500
Who is responsible for updating the Trello board?
Everyone.
No one likes doing documentation, but it's what separates good devs from mediocre ones. The only way a future employer will know if you are any good is by how well you can explain what you developed. Creating good documentation helps build that skill.